truncate unused_ports to reduce the size of app_versions.json #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stavros-k i'll fix this in https://ixsystems.atlassian.net/browse/NAS-130223 - changes currently won't cater to this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generated app_versions.json file is HUGE due to the unused ports.
Considering the values are generated on the fly each time, I think the app_versions.json does not need to list all the ports, just 1 or 2 or 3. or maybe 0?
https://raw.githubusercontent.com/truenas/apps/09c9e5f1205127b475a023290a8e266c1361a5e4/trains/charts/plex/app_versions.json
I'm not sure if this is the right place to manipulate this. Feel free to update or make a new PR!