Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-130223 / 24.10 / Don't normalize apps versions data while caching #40

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

Qubad786
Copy link
Contributor

Problem

Currently, catalog updates are generating app caches with normalized question schemas. This normalization is not needed in the cache as it increases the size of the cache file and is totally irrelevant and redundant.

Solution

Make changes to avoid normalizing the question schema while generating app versions cache files.

@Qubad786 Qubad786 requested a review from a team July 31, 2024 10:00
@bugclerk
Copy link

@bugclerk bugclerk changed the title Don't normalize apps versions data while caching NAS-130223 / 24.10 / Don't normalize apps versions data while caching Jul 31, 2024
@Qubad786 Qubad786 merged commit afe659a into master Jul 31, 2024
2 checks passed
@Qubad786 Qubad786 deleted the NAS-130223 branch July 31, 2024 14:36
@bugclerk
Copy link

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Jul 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants