NAS-130449 / 24.10 / Improve validation for apps #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugclerk
changed the title
sonicaj
reviewed
Aug 6, 2024
Qubad786
force-pushed
the
mrehan/fix-invalid-metadata
branch
from
759da32
to
e5de889
Compare
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Having
screenshots/categorieskeys in app'sapp.yamlis not a requirement but if they were added by app dev, we were not validating them. In this case misconfigured values for them have been added which is causing CI to fail and apps_validation should be catching this sooner.Solution
Properly make sure the app being validated in question is validated properly for these extra keys as well.