Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-130493 / 24.10 / Provide min/max for port ref #44

Merged
merged 2 commits into from
Aug 8, 2024
Merged

Conversation

sonicaj
Copy link
Member

@sonicaj sonicaj commented Aug 8, 2024

This commit adds changes to provide min/max for port ref and no longer populates an enum.

This commit adds changes to provide min/max for port ref and no longer populates an enum.
@sonicaj sonicaj requested a review from a team August 8, 2024 04:02
@sonicaj sonicaj self-assigned this Aug 8, 2024
@bugclerk bugclerk changed the title Provide min/max for port ref NAS-130493 / 24.10 / Provide min/max for port ref Aug 8, 2024
@bugclerk
Copy link

bugclerk commented Aug 8, 2024

catalog_reader/questions.py Outdated Show resolved Hide resolved
@sonicaj sonicaj merged commit 223cf12 into master Aug 8, 2024
2 checks passed
@sonicaj sonicaj deleted the NAS-130493 branch August 8, 2024 07:50
@bugclerk
Copy link

bugclerk commented Aug 8, 2024

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Aug 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants