ci: make bump optional #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes bumping version in CI optional.
Reasoning is that renovate calls this script on each dep update.
For example if an app have multiple containers, it will call it for each one of them.
That by itself is not an issue as wrap it in a bash script and call it once.
https://github.com/truenas/apps/blob/18c3dbfaf58341166c599b578ecf03ff4bc71d09/.github/scripts/renovate_bump.sh#L23-L25
However that means that if renovate calls the script FIRST for a container that is not the "main" container.
The app_version will never be bumped.
Solution is to call this script on every container, but only bump once.
This is paired with truenas/apps#410