PD-1252 / 25.04 / Pd 1252 update/replace smb home shares content #3158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the /shares/SMB/_index.md file with new information on the Private SMB Datasets and Shares preset, fixes style issues, and clarifies other content. It makes initial and minor edits to the Home Shares article
This commit updates the content and screenshots in the AddSMBHomeShare.md tutorial to show setting up the dataset, share, ACL preset, and adding the user home directory to use the *private* dataset, which is the alternative to using home shares.
bugclerk
changed the title
This commit updates the Other Options screenshot and adds Additional Parameters String to the list of setting options.
This commit adds the close expand shortcode to the tutorial /shares/smb/_index.md file.
|
Requesting a review by Andrew to verify the procedure and settings included are correct, and for general feedback on the changes to the AddSMBHomeShare.md article. |
DjP-iX
requested changes
Oct 29, 2024
DjP-iX
added
the
Technical Writer Review (DP)
Co-authored-by: DjP-iX <[email protected]>
Co-authored-by: DjP-iX <[email protected]>
Added Service back to the heading on line 261
Co-authored-by: DjP-iX <[email protected]>
Co-authored-by: DjP-iX <[email protected]>
Co-authored-by: DjP-iX <[email protected]>
Co-authored-by: DjP-iX <[email protected]>
Clarify line 19 and 78
#3173) * Update _index.md * Update SMBSharesScreens.md * Create SMBPurposePresets.md
|
Changes look good! Soft approved, but want to get SME feedback before we merge it. |
This commit fixes the bold emphasis issue in the Edit Filesystem ACL Screen section.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR can backport to 24.10 and 24.04
This PR updates the content in the SMB Shares UI ref and tutorials in /sharing/smb/_index.md and AddSMBHomeShare.md articles.
Content updates cover the alternative method to creating home shares.
Thanks for contributing to TrueNAS documentation! By opening a Pull Request, you're acknowledging that your changes will be distributed under the Creative Commons 4.0 license.