NAS-132534 / 25.04 / Add jbof and rdma #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #242 +/- ##
==========================================
- Coverage 91.27% 91.09% -0.18%
==========================================
Files 103 103
Lines 2339 2348 +9
==========================================
+ Hits 2135 2139 +4
- Misses 204 209 +5 ☔ View full report in Codecov by Sentry. |
yocalebo
reviewed
Nov 14, 2024
ixdiagnose/plugins/network.py
Outdated
| MiddlewareCommand('rdma.capable_protocols', result_key='capable_protocols'), | ||
| MiddlewareCommand('rdma.get_card_choices', result_key='card_choices'), | ||
| MiddlewareCommand('rdma.get_link_choices', [True], result_key='all_link_choices'), | ||
| MiddlewareCommand('rdma.get_link_choices', result_key='link_choices'), |
There was a problem hiding this comment.
What does link_choices show that all_link_choices doesn't?
There was a problem hiding this comment.
It makes it clear which links are currently configured (e.g. as a regular network interface).
yocalebo
approved these changes
Nov 15, 2024
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed these were missing.
(Currently WIP because want to do further testing.)