Allow configuring ha_propagate default per-service

src/middlewared/middlewared/plugins/service.py

@@ -89,6 +89,12 @@ def result(task):
     async def service_extend(self, svc, ctx):
         return svc | ctx.get(svc['service'], {'state': 'UNKNOWN', 'pids': []})
 
+    async def __normalize_service_options(self, svc_obj, options):
+        if options.get('ha_propagate') != None:
+            return options
+
+        return options | {'ha_propagate': svc_obj.default_ha_propagate}
+
     @filterable
     async def query(self, filters, options):
         """
@@ -149,7 +155,7 @@ async def do_update(self, app, id_or_name, data):
         Str('service'),
         Dict(
             'service-control',
-            Bool('ha_propagate', default=True),
+            Bool('ha_propagate'),
             Bool('silent', default=True),
             register=True,
         ),
@@ -166,6 +172,8 @@ async def start(self, app, service, options):
         """
         service_object = await self.middleware.call('service.object', service)
 
+        options = await self.__normalize_service_options(service_object, options)
+
         if not app_has_write_privilege_for_service(app, service):
             raise CallError(f'{service}: authenticated session lacks privilege to start service', errno.EPERM)
 
@@ -249,6 +257,8 @@ async def stop(self, app, service, options):
         """
         service_object = await self.middleware.call('service.object', service)
 
+        options = await self.__normalize_service_options(service_object, options)
+
         if not app_has_write_privilege_for_service(app, service):
             raise CallError(f'{service}: authenticated session lacks privilege to stop service')
 
@@ -285,6 +295,8 @@ async def restart(self, app, service, options):
         """
         service_object = await self.middleware.call('service.object', service)
 
+        options = await self.__normalize_service_options(service_object, options)
+
         if not app_has_write_privilege_for_service(app, service):
             raise CallError(f'{service}: authenticated session lacks privilege to restart service', errno.EPERM)
 
@@ -347,6 +359,8 @@ async def reload(self, app, service, options):
         """
         service_object = await self.middleware.call('service.object', service)
 
+        options = await self.__normalize_service_options(service_object, options)
+
         if not app_has_write_privilege_for_service(app, service):
             raise CallError(f'{service}: authenticated session lacks privilege to restart service', errno.EPERM)
 

src/middlewared/middlewared/plugins/service_/services/base_interface.py

@@ -5,6 +5,7 @@ class ServiceInterface:
     restartable = False  # Implements `restart` method instead of `stop` + `start`
     reloadable = False  # Implements `reload` method
     deprecated = False  # Alert if service is running
+    default_ha_propagate = True # If HA propagate service changes to other node
 
     def __init__(self, middleware):
         self.middleware = middleware

src/middlewared/middlewared/plugins/service_/services/cifs.py

@@ -7,6 +7,7 @@
 class CIFSService(SimpleService):
     name = "cifs"
     reloadable = True
+    default_ha_propagate = False
 
     etc = ["smb"]
 

src/middlewared/middlewared/plugins/service_/services/idmap.py

@@ -5,6 +5,7 @@ class IdmapService(SimpleService):
     name = "idmap"
     reloadable = True
     restartable = True
+    default_ha_propagate = False
 
     systemd_unit = "winbind"
 

src/middlewared/middlewared/plugins/service_/services/mdns.py

@@ -4,6 +4,7 @@
 class MDNSService(SimpleService):
     name = "mdns"
     reloadable = True
+    default_ha_propagate = False
 
     etc = ["mdns"]
 

src/middlewared/middlewared/plugins/service_/services/nfs.py

@@ -6,6 +6,7 @@
 class NFSService(SimpleService):
     name = "nfs"
     reloadable = True
+    default_ha_propagate = False
 
     etc = ["nfsd"]
 

src/middlewared/middlewared/plugins/service_/services/nslcd.py

@@ -3,5 +3,6 @@
 
 class NSSPamLdapdService(SimpleService):
     name = "nslcd"
+    default_ha_propagate = False
 
     systemd_unit = "nslcd"

src/middlewared/middlewared/plugins/service_/services/pseudo/misc.py

@@ -199,6 +199,7 @@ async def reload(self):
 
 class DSCacheService(PseudoServiceBase):
     name = "dscache"
+    default_ha_propagate = False
 
     async def start(self):
         await self.middleware.call('dscache.refresh')

src/middlewared/middlewared/plugins/service_/services/wsd.py

@@ -3,6 +3,7 @@
 
 class WSDService(SimpleService):
     name = "wsdd"
+    default_ha_propagate = False
 
     etc = ["wsd"]