Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NAS-128675 / 13.3 / It is not possible to detach attached drive from boot poo… #10102

Merged
merged 1 commit into from
May 24, 2024
Merged

NAS-128675 / 13.3 / It is not possible to detach attached drive from boot poo… #10102

merged 1 commit into from
May 24, 2024

Conversation

undsoft
Copy link
Collaborator

@undsoft undsoft commented May 23, 2024

See ticket.

Not sure why those lines were added.

@undsoft undsoft requested a review from a team as a code owner May 23, 2024 14:38
@undsoft undsoft requested review from denysbutenko and removed request for a team May 23, 2024 14:38
@bugclerk bugclerk changed the title NAS-128675: It is not possible to detach attached drive from boot poo… NAS-128675 / 13.3 / It is not possible to detach attached drive from boot poo… May 23, 2024
@bugclerk
Copy link
Contributor

Jira URL: https://ixsystems.atlassian.net/browse/NAS-128675

denysbutenko
denysbutenko approved these changes May 23, 2024
View reviewed changes
Copy link
Member

@denysbutenko denysbutenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to limitations, I couldn't attach or replace a disk from boot pool on test VM. The system from the ticket also does not work with this image.

I assume it works fine.

AlexKarpov98
AlexKarpov98 approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor

@AlexKarpov98 AlexKarpov98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@undsoft undsoft merged commit fe455fe into truenas/13.3-stable May 24, 2024
3 checks passed
@undsoft undsoft deleted the NAS-128675 branch May 24, 2024 13:08
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators May 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AlexKarpov98 AlexKarpov98 AlexKarpov98 approved these changes

@denysbutenko denysbutenko denysbutenko approved these changes

Assignees
No one assigned
Labels
no-time-tracked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@undsoft @bugclerk @denysbutenko @AlexKarpov98