Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cs.json #10478

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Update cs.json #10478

merged 2 commits into from
Sep 16, 2024

Conversation

markrieder
Copy link
Contributor

Changes:

Testing:

Downstream

Affects Reasoning
Documentation

@markrieder markrieder requested a review from a team as a code owner August 15, 2024 23:00
@markrieder markrieder requested review from AlexKarpov98 and removed request for a team August 15, 2024 23:00
Copy link
Collaborator

@undsoft undsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. There are a couple of syntax mistakes in your json file.

src/assets/i18n/cs.json Outdated Show resolved Hide resolved
src/assets/i18n/cs.json Outdated Show resolved Hide resolved
Copy link
Contributor

@AlexKarpov98 AlexKarpov98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with Evgeny.

@AlexKarpov98
Copy link
Contributor

@undsoft @markrieder - that's the maximum I was able to fix.

This PR https://github.com/truenas/webui/pull/10316/files has more translations, but they all are incorrectly formatted, and I don't know how to inject them properly, and seems it'll be easier to add them again, instead of trying to understand where to inject which phrase.

Screenshot 2024-09-13 at 12 16 38

It's better to create a new PR, for the missing translations, please.

@markrieder - thank you for your contribution.
Please go ahead and add more translations, now you have a correct understanding how it works ✊

@AlexKarpov98 AlexKarpov98 self-assigned this Sep 13, 2024
@undsoft undsoft merged commit 1cf6647 into truenas:master Sep 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants