NAS-131013 / 25.04 / Migrate more components to signal inputs #10621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/app/modules/layout/components/secondary-menu/secondary-menu.component.ts # src/app/modules/layout/secondary-menu/secondary-menu.component.spec.ts
bugclerk
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10621 +/- ##
==========================================
+ Coverage 79.75% 79.78% +0.02%
==========================================
Files 1562 1562
Lines 51325 51330 +5
Branches 5846 5843 -3
==========================================
+ Hits 40935 40954 +19
+ Misses 10390 10376 -14 ☔ View full report in Codecov by Sentry. |
# Conflicts: # src/app/pages/audit/components/event-data-details-card/event-data-details-card.component.html # src/app/pages/audit/components/event-data-details-card/event-data-details-card.component.ts
denysbutenko
approved these changes
Sep 9, 2024
| } | ||
| protected readonly datasetCompression = computed(() => { | ||
| return this.dataset()?.compression?.source === ZfsPropertySource.Inherited | ||
| ? `Inherit (${this.dataset().compression?.value})` |
|
The login image has slightly changed.
|
# Conflicts: # src/assets/i18n/fr.json
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also optimizes images on login page.
Testing:
Test something affected.