Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-129412 / 25.04 / Improve messaging in netdata dialog #10643

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Conversation

undsoft
Copy link
Collaborator

@undsoft undsoft commented Sep 9, 2024

Changes:

Just a bit of helptext for the user.

@undsoft undsoft requested a review from a team as a code owner September 9, 2024 15:00
@undsoft undsoft requested review from bvasilenko and removed request for a team September 9, 2024 15:00
@bugclerk bugclerk changed the title NAS-129412: Improve messaging in netdata dialog NAS-129412 / 25.04 / Improve messaging in netdata dialog Sep 9, 2024
@bugclerk
Copy link
Contributor

bugclerk commented Sep 9, 2024

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.74%. Comparing base (a2640a0) to head (041091c).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10643      +/-   ##
==========================================
- Coverage   79.75%   79.74%   -0.01%     
==========================================
  Files        1562     1562              
  Lines       51325    51325              
  Branches     5846     5846              
==========================================
- Hits        40935    40931       -4     
- Misses      10390    10394       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@bvasilenko bvasilenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@undsoft undsoft added the backport-24.10-RC.1 Electric Eel RC1 label Sep 10, 2024
@undsoft undsoft merged commit 3447628 into master Sep 10, 2024
9 checks passed
@undsoft undsoft deleted the NAS-129412 branch September 10, 2024 08:44
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Sep 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants