Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-131092 / 25.04 / Remove ngx-layout #10648

Merged
merged 6 commits into from
Sep 16, 2024
Merged

NAS-131092 / 25.04 / Remove ngx-layout #10648

merged 6 commits into from
Sep 16, 2024

Conversation

undsoft
Copy link
Collaborator

@undsoft undsoft commented Sep 10, 2024

Testing:

Test affected places.

@undsoft undsoft requested a review from a team as a code owner September 10, 2024 11:51
@undsoft undsoft requested review from RehanY147 and removed request for a team September 10, 2024 11:52
@bugclerk
Copy link
Contributor

@bugclerk bugclerk changed the title NAS-131092: Remove ngx-layout NAS-131092 / 25.04 / Remove ngx-layout Sep 10, 2024
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 80.55556% with 7 lines in your changes missing coverage. Please review.

Project coverage is 79.89%. Comparing base (25da2b4) to head (f1d7bcd).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/app/services/sidenav.service.ts 84.00% 4 Missing ⚠️
...ectives/details-height/details-height.directive.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10648      +/-   ##
==========================================
+ Coverage   79.81%   79.89%   +0.07%     
==========================================
  Files        1562     1562              
  Lines       51355    51349       -6     
  Branches     5847     5847              
==========================================
+ Hits        40989    41024      +35     
+ Misses      10366    10325      -41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@RehanY147 RehanY147 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting this error on Apps dashboard and VM dashboard table
image

@undsoft undsoft merged commit 515e04a into master Sep 16, 2024
9 checks passed
@undsoft undsoft deleted the NAS-131092 branch September 16, 2024 11:59
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Sep 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants