NAS-130943 / 25.04 / Fix apps bulk upgrade #10656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugclerk
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10656 +/- ##
==========================================
+ Coverage 79.77% 79.81% +0.03%
==========================================
Files 1562 1562
Lines 51340 51347 +7
Branches 5845 5846 +1
==========================================
+ Hits 40957 40982 +25
+ Misses 10383 10365 -18 ☔ View full report in Codecov by Sentry. |
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Fixes issue where select input exists when the user has not expanded the panel. Makes the form status invalid.
Testing:
Add the
testtrain. Install older version1.0.5ornginxapp from thetesttrain. Install a couple of instances of the same app and same version. Then go to bulk upgrade dialog. Only expand one of the apps panel to choose the exact version to upgrade to. Leave the other app panel alone. Click the upgrade button. Both apps should upgrade correctly.