Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-131113 / 24.10-RC.1 / Show block IO stats (by undsoft) #10662

Merged
merged 3 commits into from
Sep 11, 2024

Conversation

bugclerk
Copy link
Contributor

Automatic cherry-pick failed. Please resolve conflicts by running:

git reset --hard HEAD~1
git cherry-pick -x c86fb46d8a0c29521fbf808e737469b99be7d18e
git cherry-pick -x 45a3c92c5796636d5ede41bb299e22c22149b3c2

If the original PR was merged via a squash, you can just cherry-pick the squashed commit:

git reset --hard HEAD~1
git cherry-pick -x 5adb573d29999d72c0c75181b5c46a214a1f46c6

Changes:

Adds new block IO column to apps.

Testing:

Check new column

Downstream

Affects Reasoning
Documentation New Block IO column in apps.

Original PR: #10660
Jira URL: https://ixsystems.atlassian.net/browse/NAS-131113

@AlexKarpov98 AlexKarpov98 marked this pull request as ready for review September 11, 2024 13:54
@AlexKarpov98 AlexKarpov98 requested a review from a team as a code owner September 11, 2024 13:54
@AlexKarpov98 AlexKarpov98 requested review from RehanY147 and removed request for a team September 11, 2024 13:54
@AlexKarpov98 AlexKarpov98 enabled auto-merge (squash) September 11, 2024 13:56
Copy link
Contributor

@AlexKarpov98 AlexKarpov98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ported.

Copy link
Contributor

@RehanY147 RehanY147 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The table looks a little messed up. The row select checkbox is messed up if you scroll horizontally. Also, the table has to be scrolled around horizontally but that might be intended behavior.

@AlexKarpov98
Copy link
Contributor

@RehanY147 - it's merged in master already.
For scrolling I've created a separate ticket.
https://ixsystems.atlassian.net/browse/NAS-131117

@undsoft
Copy link
Collaborator

undsoft commented Sep 11, 2024

Yeah, true, I'm going to merge anyway because of the codefreeze and because it's a minor issue.

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (stable/electriceel@3ac3377). Learn more about missing BASE report.

Additional details and impacted files
@@                  Coverage Diff                  @@
##             stable/electriceel   #10662   +/-   ##
=====================================================
  Coverage                      ?   79.76%           
=====================================================
  Files                         ?     1569           
  Lines                         ?    51314           
  Branches                      ?     5922           
=====================================================
  Hits                          ?    40933           
  Misses                        ?    10381           
  Partials                      ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@undsoft undsoft merged commit c907879 into stable/electriceel Sep 11, 2024
9 checks passed
@undsoft undsoft deleted the NAS-131113-24.10-RC.1 branch September 11, 2024 17:21
@bugclerk
Copy link
Contributor Author

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants