-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NAS-131113 / 24.10-RC.1 / Show block IO stats (by undsoft) #10662
Conversation
You should reset it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ported.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The table looks a little messed up. The row select checkbox is messed up if you scroll horizontally. Also, the table has to be scrolled around horizontally but that might be intended behavior.
@RehanY147 - it's merged in master already. |
Yeah, true, I'm going to merge anyway because of the codefreeze and because it's a minor issue. |
a59ca3e
to
8c9249f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stable/electriceel #10662 +/- ##
=====================================================
Coverage ? 79.76%
=====================================================
Files ? 1569
Lines ? 51314
Branches ? 5922
=====================================================
Hits ? 40933
Misses ? 10381
Partials ? 0 ☔ View full report in Codecov by Sentry. |
This PR has been merged and conversations have been locked. |
Automatic cherry-pick failed. Please resolve conflicts by running:
If the original PR was merged via a squash, you can just cherry-pick the squashed commit:
Changes:
Adds new block IO column to apps.
Testing:
Check new column
Downstream
Original PR: #10660
Jira URL: https://ixsystems.atlassian.net/browse/NAS-131113