Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-131140 / 25.04 / Refactor directives and dialogs to standalone components #10667

Merged
merged 4 commits into from
Sep 16, 2024

Conversation

undsoft
Copy link
Collaborator

@undsoft undsoft commented Sep 12, 2024

Testing:
Test something affected.

@undsoft undsoft requested a review from a team as a code owner September 12, 2024 13:45
@undsoft undsoft requested review from RehanY147 and removed request for a team September 12, 2024 13:45
@bugclerk bugclerk changed the title NAS-131140: Refactor directives and dialogs to standalone components NAS-131140 / 25.04 / Refactor directives and dialogs to standalone components Sep 12, 2024
@bugclerk
Copy link
Contributor

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 92.38095% with 8 lines in your changes missing coverage. Please review.

Project coverage is 79.69%. Comparing base (25da2b4) to head (ca6c546).
Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
...omponents/update-dialog/update-dialog.component.ts 0.00% 6 Missing ⚠️
src/app/modules/layout/topbar/topbar.component.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10667      +/-   ##
==========================================
- Coverage   79.81%   79.69%   -0.12%     
==========================================
  Files        1562     1562              
  Lines       51355    51479     +124     
  Branches     5847     5852       +5     
==========================================
+ Hits        40989    41028      +39     
- Misses      10366    10451      +85     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@RehanY147 RehanY147 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@undsoft undsoft merged commit dca5277 into master Sep 16, 2024
9 checks passed
@undsoft undsoft deleted the NAS-131140 branch September 16, 2024 11:59
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Sep 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants