Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-131135 / 25.04 / Better indication for true cloud backup restoration #10671

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

undsoft
Copy link
Collaborator

@undsoft undsoft commented Sep 12, 2024

Changes:

Previous implementation used incorrect callback (next instead of complete). Switched to showing a dialog.

@undsoft undsoft requested a review from a team as a code owner September 12, 2024 17:42
@undsoft undsoft requested review from bvasilenko and removed request for a team September 12, 2024 17:42
@bugclerk bugclerk changed the title NAS-131135: Better indication for true cloud backup restoration NAS-131135 / 25.04 / Better indication for true cloud backup restoration Sep 12, 2024
@bugclerk
Copy link
Contributor

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.81%. Comparing base (8d7d24e) to head (347f915).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10671   +/-   ##
=======================================
  Coverage   79.81%   79.81%           
=======================================
  Files        1562     1562           
  Lines       51394    51398    +4     
  Branches     5851     5851           
=======================================
+ Hits        41019    41023    +4     
  Misses      10375    10375           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@bvasilenko bvasilenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works without issues

@undsoft undsoft merged commit 08d3323 into master Sep 16, 2024
9 checks passed
@undsoft undsoft deleted the NAS-131135 branch September 16, 2024 08:02
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Sep 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants