-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NAS-131036 / 25.04 / Remove use of chain
method from 'lodash-es'
#10716
Conversation
chain
method from 'lodash-es'
chain
method from 'lodash-es'
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10716 +/- ##
==========================================
+ Coverage 80.19% 80.21% +0.01%
==========================================
Files 1570 1570
Lines 51623 51626 +3
Branches 5834 5834
==========================================
+ Hits 41401 41410 +9
+ Misses 10222 10216 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Let's also ban via linter rules. |
This PR has been merged and conversations have been locked. |
Changes:
Fixes uses of
chain
method fromlodash-es
. We should either be callingchain
via_.chain
or use individual methods without chaining. Usingchain
fromimport { chain } from 'lodash-es';
is not advisable because it doesn't include any of the methods so you can't call methods on the collection returned bychain
method.Testing:
Test that breadcrumbs in places like datasets/snapshots or shares/smb etc are showing up. Test in enclosure dashboard. Check console for errors.