Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-131360 / 25.04 / Remove root user from set initial password form #10734

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

undsoft
Copy link
Collaborator

@undsoft undsoft commented Sep 23, 2024

Changes:

Changes to initial password form.

Снимок экрана 2024-09-23 в 14 13 23

Testing:
General Settings -> Reset Config.
Easier to use non-HA CI system for that. You may need to wait after config has been reset.

Downstream

Affects Reasoning
Documentation It is not longer possible to use root when setting initial admin password.

@undsoft undsoft requested a review from a team as a code owner September 23, 2024 12:13
@undsoft undsoft requested review from bvasilenko and removed request for a team September 23, 2024 12:13
@bugclerk bugclerk changed the title NAS-131360: Remove root user from set initial password form NAS-131360 / 25.04 / Remove root user from set initial password form Sep 23, 2024
@bugclerk
Copy link
Contributor

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.20%. Comparing base (7f3637e) to head (c69d46a).
Report is 10 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10734      +/-   ##
==========================================
+ Coverage   80.14%   80.20%   +0.05%     
==========================================
  Files        1567     1570       +3     
  Lines       51592    51623      +31     
  Branches     5832     5834       +2     
==========================================
+ Hits        41349    41404      +55     
+ Misses      10243    10219      -24     
Flag Coverage Δ
80.20% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@AlexKarpov98 AlexKarpov98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected.

Copy link
Contributor

@bvasilenko bvasilenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected!

@undsoft undsoft merged commit 24b2ae0 into master Sep 24, 2024
9 checks passed
@undsoft undsoft deleted the NAS-131360 branch September 24, 2024 10:07
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Sep 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants