Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-131372 / 25.04 / Cannot edit link user #10738

Merged
merged 1 commit into from
Sep 24, 2024
Merged

NAS-131372 / 25.04 / Cannot edit link user #10738

merged 1 commit into from
Sep 24, 2024

Conversation

undsoft
Copy link
Collaborator

@undsoft undsoft commented Sep 24, 2024

Changes
Remove function was called incorrectly.

Testing:
Previous issue was reproducible by creating a user with link username and then trying to edit it.

@undsoft undsoft requested a review from a team as a code owner September 24, 2024 07:55
@undsoft undsoft requested review from bvasilenko and removed request for a team September 24, 2024 07:55
@bugclerk bugclerk changed the title NAS-131372: Cannot edit link user NAS-131372 / 25.04 / Cannot edit link user Sep 24, 2024
@bugclerk
Copy link
Contributor

Copy link
Contributor

@AlexKarpov98 AlexKarpov98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.20%. Comparing base (b237815) to head (2274cd9).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10738      +/-   ##
==========================================
- Coverage   80.21%   80.20%   -0.01%     
==========================================
  Files        1570     1570              
  Lines       51626    51624       -2     
  Branches     5834     5834              
==========================================
- Hits        41410    41405       -5     
- Misses      10216    10219       +3     
Flag Coverage Δ
80.20% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@bvasilenko bvasilenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@undsoft undsoft merged commit f6d82ca into master Sep 24, 2024
7 checks passed
@undsoft undsoft deleted the NAS-131372 branch September 24, 2024 10:06
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Sep 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants