Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-131272 / 25.04 / App name issue in UI #10740

Merged
merged 1 commit into from
Sep 26, 2024
Merged

NAS-131272 / 25.04 / App name issue in UI #10740

merged 1 commit into from
Sep 26, 2024

Conversation

AlexKarpov98
Copy link
Contributor

Testing: see ticket.

I've added new mixin for line-clamp handling.

Screenshot 2024-09-24 at 11 29 01

@AlexKarpov98 AlexKarpov98 self-assigned this Sep 24, 2024
@AlexKarpov98 AlexKarpov98 requested a review from a team as a code owner September 24, 2024 08:29
@AlexKarpov98 AlexKarpov98 requested review from denysbutenko and removed request for a team September 24, 2024 08:29
@bugclerk bugclerk changed the title NAS-131272: App name issue in UI NAS-131272 / 25.04 / App name issue in UI Sep 24, 2024
@bugclerk
Copy link
Contributor

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.21%. Comparing base (8e5e6c9) to head (c5028bb).
Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10740      +/-   ##
==========================================
+ Coverage   80.19%   80.21%   +0.01%     
==========================================
  Files        1570     1570              
  Lines       51623    51626       +3     
  Branches     5834     5834              
==========================================
+ Hits        41401    41410       +9     
+ Misses      10222    10216       -6     
Flag Coverage Δ
80.21% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@denysbutenko denysbutenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Looks good

@AlexKarpov98 AlexKarpov98 merged commit d7e8d0c into master Sep 26, 2024
7 checks passed
@AlexKarpov98 AlexKarpov98 deleted the NAS-131272 branch September 26, 2024 10:22
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Sep 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants