NAS-131130 / 25.04 / Refactor subscribeToInstalledAppsUpdates in installed-apps-store.service

[AlexKarpov98]

Refactoring. (messy code fix)

[bugclerk]

Jira URL: https://ixsystems.atlassian.net/browse/NAS-131130

[denysbutenko]

I have been looking into this code for the last few days. Some points that I highlighted:

• We may need to split the logic for installed apps and available apps into corresponding files.
• app.query have support callAndSubscribe to handle collection changes
• recommendedApps is a subset of availableApps like computed property.

Just shared thoughts, this is not a call to action

[AlexKarpov98]

@denysbutenko - thanks.
My original thoughts regarding this PR - it's refactoring, to make it much easier to read, understand the code and not have a huge canvas of one function.

[codecov]

Codecov Report

Attention: Patch coverage is 5.12821% with 37 lines in your changes missing coverage. Please review.

Project coverage is 80.27%. Comparing base (480d675) to head (4494a11).
Report is 31 commits behind head on master.

Files with missing lines	Patch %	Lines
...p/pages/apps/store/installed-apps-store.service.ts	5.12%	37 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #10741      +/-   ##
==========================================
+ Coverage   80.12%   80.27%   +0.15%     
==========================================
  Files        1567     1571       +4     
  Lines       51516    51660     +144     
  Branches     5832     5840       +8     
==========================================
+ Hits        41275    41469     +194     
+ Misses      10241    10191      -50     

Flag	Coverage Δ
	80.27% <5.12%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bugclerk]

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.