Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-131100 / 25.04 / Fix installed apps is empty on app install #10745

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

denysbutenko
Copy link
Member

Changes:

Reload installed apps on first app install

Testing:

On fresh nightly system when docker service is not configured and you try to install an app for first time. Ensure apps tree shows newly installed app.

@denysbutenko denysbutenko requested a review from a team as a code owner September 25, 2024 07:44
@denysbutenko denysbutenko requested review from undsoft and removed request for a team September 25, 2024 07:44
@bugclerk bugclerk changed the title NAS-131100: Fix installed apps is empty on app install NAS-131100 / 25.04 / Fix installed apps is empty on app install Sep 25, 2024
@bugclerk
Copy link
Contributor

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.20%. Comparing base (b237815) to head (9179593).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10745      +/-   ##
==========================================
- Coverage   80.21%   80.20%   -0.01%     
==========================================
  Files        1570     1570              
  Lines       51626    51622       -4     
  Branches     5834     5833       -1     
==========================================
- Hits        41410    41405       -5     
- Misses      10216    10217       +1     
Flag Coverage Δ
80.20% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@undsoft undsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Backport to 24.10.0 if necessary.

@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Sep 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants