Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-131148 / 25.04 / Audit logs on HA - Add ability to view and export remote controller logs in the WebUI #10746

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

AlexKarpov98
Copy link
Contributor

Testing:
See ticket.
Make sure you have latest Fangtooth VM & HA system.
Go to the Audit page.

Result 👇

NAS-131148.mov
Affects Reasoning
Documentation Added 2 new buttons to show logs based on the HA controller.

@AlexKarpov98 AlexKarpov98 self-assigned this Sep 25, 2024
@AlexKarpov98 AlexKarpov98 requested a review from a team as a code owner September 25, 2024 08:07
@AlexKarpov98 AlexKarpov98 requested review from denysbutenko and removed request for a team September 25, 2024 08:07
@AlexKarpov98 AlexKarpov98 changed the title NAS-131148: NAS-131148: Audit logs on HA - Add ability to view and export remote controller logs in the WebUI Sep 25, 2024
@bugclerk
Copy link
Contributor

@bugclerk bugclerk changed the title NAS-131148: Audit logs on HA - Add ability to view and export remote controller logs in the WebUI NAS-131148 / 25.04 / Audit logs on HA - Add ability to view and export remote controller logs in the WebUI Sep 25, 2024
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 92.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 80.21%. Comparing base (24b2ae0) to head (6426595).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...pp/pages/audit/components/audit/audit.component.ts 85.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10746   +/-   ##
=======================================
  Coverage   80.20%   80.21%           
=======================================
  Files        1570     1571    +1     
  Lines       51624    51654   +30     
  Branches     5834     5840    +6     
=======================================
+ Hits        41405    41433   +28     
- Misses      10219    10221    +2     
Flag Coverage Δ
80.21% <92.50%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@denysbutenko denysbutenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@@ -1,4 +1,12 @@
<ix-page-header>
@if (isHaLicensed()) {
<p>{{ 'Controller' | translate }}</p>
<mat-button-toggle-group [value]="controllerType()" (change)="controllerTypeChanged($event)">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is similar ix-button-group that accepts options$

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@denysbutenko we may add a new ticket to convert all of these to use <ix-button-group /> then.

Screenshot 2024-09-26 at 13 44 35

@AlexKarpov98 AlexKarpov98 merged commit 6708d3d into master Sep 26, 2024
9 checks passed
@AlexKarpov98 AlexKarpov98 deleted the NAS-131148 branch September 26, 2024 10:44
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Sep 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants