-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NAS-131148 / 25.04 / Audit logs on HA - Add ability to view and export remote controller logs in the WebUI #10746
Conversation
…controller logs in the WebUI
…controller logs in the WebUI
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10746 +/- ##
=======================================
Coverage 80.20% 80.21%
=======================================
Files 1570 1571 +1
Lines 51624 51654 +30
Branches 5834 5840 +6
=======================================
+ Hits 41405 41433 +28
- Misses 10219 10221 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
@@ -1,4 +1,12 @@ | |||
<ix-page-header> | |||
@if (isHaLicensed()) { | |||
<p>{{ 'Controller' | translate }}</p> | |||
<mat-button-toggle-group [value]="controllerType()" (change)="controllerTypeChanged($event)"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is similar ix-button-group
that accepts options$
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@denysbutenko we may add a new ticket to convert all of these to use <ix-button-group />
then.
This PR has been merged and conversations have been locked. |
Testing:
See ticket.
Make sure you have latest Fangtooth VM & HA system.
Go to the Audit page.
Result 👇
NAS-131148.mov