Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-131390 / 25.04 / Optimize apps widgets on dashboard #10748

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

denysbutenko
Copy link
Member

Changes:

Optimize calls when many different app widgets are added to the dashboard.

Testing:

Add every app's widget for two apps.

@denysbutenko denysbutenko requested a review from a team as a code owner September 25, 2024 09:05
@denysbutenko denysbutenko requested review from bvasilenko and removed request for a team September 25, 2024 09:05
@bugclerk bugclerk changed the title NAS-131390: Optimize apps widgets on dashboard NAS-131390 / 25.04 / Optimize apps widgets on dashboard Sep 25, 2024
@bugclerk
Copy link
Contributor

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.

Project coverage is 80.20%. Comparing base (c68302b) to head (ee6e1c9).

Files with missing lines Patch % Lines
...ges/dashboard/services/widget-resources.service.ts 33.33% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10748      +/-   ##
==========================================
- Coverage   80.20%   80.20%   -0.01%     
==========================================
  Files        1570     1570              
  Lines       51623    51622       -1     
  Branches     5834     5833       -1     
==========================================
- Hits        41405    41401       -4     
- Misses      10218    10221       +3     
Flag Coverage Δ
80.20% <42.85%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@bvasilenko bvasilenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Number of calls has been decreased, looks good

@denysbutenko denysbutenko merged commit 70ae4ee into master Sep 26, 2024
6 of 7 checks passed
@denysbutenko denysbutenko deleted the NAS-131390 branch September 26, 2024 08:36
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Sep 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants