Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-131307 / 24.10.0 / Text does not fit in network widget (by AlexKarpov98) #10757

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

bugclerk
Copy link
Contributor

Automatic cherry-pick failed. Please resolve conflicts by running:

git cherry-pick -x 6bf2079d2a3cae36558e8ab6b795fb322fd37f10

If the original PR was merged via a squash, you can just cherry-pick the squashed commit:

git reset --hard HEAD~1
git cherry-pick -x 2afce47e22a34742b02f389acd312894a9880945

Testing: See ticket

Before:
before-NAS-131307

After:
after-NAS-131307

Original PR: #10751
Jira URL: https://ixsystems.atlassian.net/browse/NAS-131307

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (stable/electriceel@d398fa2). Learn more about missing BASE report.

Additional details and impacted files
@@                  Coverage Diff                  @@
##             stable/electriceel   #10757   +/-   ##
=====================================================
  Coverage                      ?   79.78%           
=====================================================
  Files                         ?     1570           
  Lines                         ?    51324           
  Branches                      ?     5924           
=====================================================
  Hits                          ?    40950           
  Misses                        ?    10374           
  Partials                      ?        0           
Flag Coverage Δ
79.78% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlexKarpov98 AlexKarpov98 marked this pull request as ready for review September 27, 2024 09:48
@AlexKarpov98 AlexKarpov98 requested a review from a team as a code owner September 27, 2024 09:48
@AlexKarpov98 AlexKarpov98 requested review from bvasilenko and removed request for a team September 27, 2024 09:48
Copy link
Contributor

@AlexKarpov98 AlexKarpov98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ported.

@AlexKarpov98 AlexKarpov98 merged commit b0470cb into stable/electriceel Sep 27, 2024
7 checks passed
@AlexKarpov98 AlexKarpov98 deleted the NAS-131307-24.10.0 branch September 27, 2024 10:48
@bugclerk
Copy link
Contributor Author

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Sep 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants