Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-131392 / 25.04 / Dashboard - Initiate Failover button - text overlapping issue #10761

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

AlexKarpov98
Copy link
Contributor

Testing: see ticket.

Result:

NAS-131392

@AlexKarpov98 AlexKarpov98 self-assigned this Sep 27, 2024
@AlexKarpov98 AlexKarpov98 requested a review from a team as a code owner September 27, 2024 10:47
@AlexKarpov98 AlexKarpov98 requested review from denysbutenko and removed request for a team September 27, 2024 10:47
@bugclerk bugclerk changed the title NAS-131392: Dashboard - Initiate Failover button - text overlapping issue NAS-131392 / 25.04 / Dashboard - Initiate Failover button - text overlapping issue Sep 27, 2024
@bugclerk
Copy link
Contributor

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.29%. Comparing base (c68302b) to head (7137d25).
Report is 11 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10761      +/-   ##
==========================================
+ Coverage   80.20%   80.29%   +0.08%     
==========================================
  Files        1570     1571       +1     
  Lines       51623    51708      +85     
  Branches     5834     5838       +4     
==========================================
+ Hits        41405    41519     +114     
+ Misses      10218    10189      -29     
Flag Coverage Δ
80.29% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@denysbutenko denysbutenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Sep 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants