Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-131421 / 24.10.0 / Improve webui professionalism (by undsoft) #10765

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

bugclerk
Copy link
Contributor

Testing:
Code review.

Original PR: #10764
Jira URL: https://ixsystems.atlassian.net/browse/NAS-131421

@bugclerk bugclerk requested a review from a team as a code owner September 27, 2024 16:26
@bugclerk bugclerk requested review from AlexKarpov98 and removed request for a team September 27, 2024 16:26
Copy link
Contributor

@AlexKarpov98 AlexKarpov98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ported.

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (stable/electriceel@a056c8c). Learn more about missing BASE report.

Additional details and impacted files
@@                  Coverage Diff                  @@
##             stable/electriceel   #10765   +/-   ##
=====================================================
  Coverage                      ?   79.80%           
=====================================================
  Files                         ?     1570           
  Lines                         ?    51328           
  Branches                      ?     5924           
=====================================================
  Hits                          ?    40962           
  Misses                        ?    10366           
  Partials                      ?        0           
Flag Coverage Δ
79.80% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@undsoft undsoft merged commit f999891 into stable/electriceel Sep 27, 2024
7 checks passed
@undsoft undsoft deleted the NAS-131421-24.10.0 branch September 27, 2024 18:40
@bugclerk
Copy link
Contributor Author

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Sep 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants