Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NAS-131283 / 24.10.0 / Provide single entry point for installing a custom app (by denysbutenko) #10767

Merged
merged 1 commit into from
Sep 30, 2024
Merged

NAS-131283 / 24.10.0 / Provide single entry point for installing a custom app (by denysbutenko) #10767

merged 1 commit into from
Sep 30, 2024

Conversation

bugclerk
Copy link
Contributor

Automatic cherry-pick failed. Please resolve conflicts by running:

git reset --hard HEAD~1
git cherry-pick -x 450e6167f305dc484e07ab4490a7bd4090919cd8
git cherry-pick -x 0351135bd14511bfc9fc60ba809ba4250d5cd66d

If the original PR was merged via a squash, you can just cherry-pick the squashed commit:

git reset --hard HEAD~1
git cherry-pick -x 43477fb6cde5c9c8c80635ce69bf3b38665a76ac

Changes:

Guide user to App Wizard when installing custom app. Allow to install an app via YAML.

Testing:

Check ticket

Downstream

Affects Reasoning
Documentation UI has changed

Original PR: #10758
Jira URL: https://ixsystems.atlassian.net/browse/NAS-131283

@denysbutenko
NAS-131283: Provide single entry point for installing a custom app (#…
65c3b21 
…10758)

* NAS-131283: Provide single entry point for installing a custom app

* NAS-131283: Provide single entry point for installing a custom app

(cherry picked from commit 43477fb)
@denysbutenko denysbutenko marked this pull request as ready for review September 30, 2024 10:23
@denysbutenko denysbutenko requested a review from a team as a code owner September 30, 2024 10:23
@denysbutenko denysbutenko requested review from undsoft and removed request for a team September 30, 2024 10:23
AlexKarpov98
AlexKarpov98 approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@AlexKarpov98 AlexKarpov98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ported.

denysbutenko
denysbutenko approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@denysbutenko denysbutenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backported

@codecov Codecov
Copy link

codecov bot commented Sep 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (stable/electriceel@f999891). Learn more about missing BASE report.

Additional details and impacted files 
@@                  Coverage Diff                  @@
##             stable/electriceel   #10767   +/-   ##
=====================================================
  Coverage                      ?   79.83%           
=====================================================
  Files                         ?     1570           
  Lines                         ?    51330           
  Branches                      ?     5924           
=====================================================
  Hits                          ?    40979           
  Misses                        ?    10351           
  Partials                      ?        0
Flag Coverage Δ
79.83% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@denysbutenko denysbutenko merged commit a527ebf into stable/electriceel Sep 30, 2024
9 checks passed
@denysbutenko denysbutenko deleted the NAS-131283-24.10.0 branch September 30, 2024 12:24
@bugclerk
Copy link
Contributor Author

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Sep 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AlexKarpov98 AlexKarpov98 AlexKarpov98 approved these changes

@denysbutenko denysbutenko denysbutenko approved these changes

@undsoft undsoft Awaiting requested review from undsoft undsoft is a code owner automatically assigned from truenas/ui-team

Assignees

@denysbutenko denysbutenko

Labels
no-time-tracked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bugclerk @denysbutenko @AlexKarpov98