Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nl.json #10818

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

renediepenbroek
Copy link
Contributor

2024-10-08

Changes:

Testing:

Downstream

Affects Reasoning
Documentation

2024-10-08
@renediepenbroek renediepenbroek requested a review from a team as a code owner October 7, 2024 13:54
@renediepenbroek renediepenbroek requested review from AlexKarpov98 and removed request for a team October 7, 2024 13:54
Copy link
Contributor

@AlexKarpov98 AlexKarpov98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, please fix meervoud issue (described below)

And pull latest changes to resolve conflicts.

"{email} via {server}": "{email} via {server}",
"{failedCount} of {allCount, plural, =1 {# task} other {# tasks}} failed": "{failedCount} van {allCount, plural, =1 {# taak is} other {# taken zijn}} mislukt",
"{license} contract, expires {date}": "{license} contract, verloopt op {date}",
"{n, plural, =0 {No errors} one {# Error} other {# Errors}}": "{n, meervoud, =0 {Geen fouten} one {# Fout} other {# fouten}}",
Copy link
Contributor

@AlexKarpov98 AlexKarpov98 Oct 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meervoud should remain plural

This issue breaks validation.

Correct version:

"{n, plural, =0 {No errors} one {# Error} other {# Errors}}": "{n, plural, =0 {Geen fouten} one {# Fout} other {# fouten}}",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants