Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-132230 / 24.10.1 / UI issue with DEPRECATED: Old Storage Structure in Nextcloud Install Wizard (by AlexKarpov98) #11031

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

bugclerk
Copy link
Contributor

Automatic cherry-pick failed. Please resolve conflicts by running:

git reset --hard HEAD~1
git cherry-pick -x 9eae2f6438b8629b4a43f403dbf933c2ad770e49

If the original PR was merged via a squash, you can just cherry-pick the squashed commit:

git reset --hard HEAD~1
git cherry-pick -x f71aabeb1ee1af50f6fb65feaacd516a53ce85dc

Testing: see ticket, result:

Screenshot 2024-11-13 at 14 24 16

Original PR: #11026
Jira URL: https://ixsystems.atlassian.net/browse/NAS-132230

@AlexKarpov98 AlexKarpov98 marked this pull request as ready for review November 15, 2024 11:02
@AlexKarpov98 AlexKarpov98 requested a review from a team as a code owner November 15, 2024 11:02
@AlexKarpov98 AlexKarpov98 requested review from AlexKarpov98 and removed request for a team November 15, 2024 11:02
Copy link
Contributor

@AlexKarpov98 AlexKarpov98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ported.

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (stable/electriceel@c3bc22e). Learn more about missing BASE report.

Additional details and impacted files
@@                  Coverage Diff                  @@
##             stable/electriceel   #11031   +/-   ##
=====================================================
  Coverage                      ?   79.98%           
=====================================================
  Files                         ?     1572           
  Lines                         ?    51438           
  Branches                      ?     5938           
=====================================================
  Hits                          ?    41144           
  Misses                        ?    10294           
  Partials                      ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlexKarpov98 AlexKarpov98 merged commit 65a454a into stable/electriceel Nov 15, 2024
11 checks passed
@AlexKarpov98 AlexKarpov98 deleted the NAS-132230-24.10.1 branch November 15, 2024 12:22
@bugclerk
Copy link
Contributor Author

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Nov 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants