Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-132503 / 25.04 / Non-local (e.g.directory services) users should not be li… #11035

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

undsoft
Copy link
Collaborator

@undsoft undsoft commented Nov 14, 2024

…sted as options for group member selector

Changes:

See ticket.

@undsoft undsoft requested a review from a team as a code owner November 14, 2024 14:44
@undsoft undsoft requested review from RehanY147 and removed request for a team November 14, 2024 14:44
@bugclerk bugclerk changed the title NAS-132503: Non-local (e.g.directory services) users should not be li… NAS-132503 / 25.04 / Non-local (e.g.directory services) users should not be li… Nov 14, 2024
@bugclerk
Copy link
Contributor

@undsoft undsoft enabled auto-merge (squash) November 15, 2024 08:59
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.84%. Comparing base (1f6c5cd) to head (4d57801).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11035      +/-   ##
==========================================
- Coverage   81.84%   81.84%   -0.01%     
==========================================
  Files        1621     1621              
  Lines       57298    57286      -12     
  Branches     5915     5915              
==========================================
- Hits        46893    46883      -10     
+ Misses      10405    10403       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@undsoft undsoft merged commit 0c71811 into master Nov 15, 2024
13 checks passed
@undsoft undsoft deleted the NAS-132503 branch November 15, 2024 09:26
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Nov 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants