NAS-122595 / UI does not allow REMOVE operations on single-device data vdevs #8421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated UI logic, lines shown below 421: show REMOVE for single-disk vdevs in mirror pools 423+426: hide ONLINE, OFFLINE, and REPLACE for spare vdev (fixed case sensitive matching) 430: hide REPLACE for cache vdev 563: hide EXTEND for cache and spare vdev
|
@undsoft Since this is going into 13.0 STABLE branch for 13.1 eventually, can I also have your quick review? Thanks! |
chrisperedun
deleted the
NAS-122595-/-UI-does-not-allow-REMOVE-operations-on-single-device-data-vdevs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated UI logic, see line references below
421: show REMOVE for single-disk vdevs in mirror pools
423+426: hide ONLINE, OFFLINE, and REPLACE for spare vdev (fixed case sensitive matching)
430: hide REPLACE for cache vdev
563: hide EXTEND for cache and spare vdev