Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NAS-122461 / 13.3 / Revert encryption value when Cancel button is pressed #9922

Merged
merged 1 commit into from
Apr 4, 2024
Merged

NAS-122461 / 13.3 / Revert encryption value when Cancel button is pressed #9922

merged 1 commit into from
Apr 4, 2024

Conversation

bvasilenko
Copy link
Contributor

Testing

see ticket

@bvasilenko bvasilenko requested a review from a team as a code owner April 3, 2024 18:26
@bvasilenko bvasilenko requested review from AlexKarpov98 and removed request for a team April 3, 2024 18:26
@bugclerk bugclerk changed the title Revert encryption value when Cancel button is pressed NAS-122461 / 13.3 / Revert encryption value when Cancel button is pressed Apr 3, 2024
@bugclerk
Copy link
Contributor

bugclerk commented Apr 3, 2024

Jira URL: https://ixsystems.atlassian.net/browse/NAS-122461

AlexKarpov98
AlexKarpov98 approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@AlexKarpov98 AlexKarpov98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Encryption value is now reverted on cancel.

@undsoft undsoft merged commit b2e8afe into truenas/13.3-stable Apr 4, 2024
3 checks passed
@undsoft undsoft deleted the NAS-122461 branch April 4, 2024 08:25
@bugclerk
Copy link
Contributor

bugclerk commented Apr 4, 2024

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Apr 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AlexKarpov98 AlexKarpov98 AlexKarpov98 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bvasilenko @bugclerk @AlexKarpov98 @undsoft