Skip to content

Commit

Permalink
[analyze] Fix double-print in postgres analyzer (#3199)
Browse files Browse the repository at this point in the history
* [analyze] Fix double-print in postgres analyzer

* Continue on error in github analyzer
  • Loading branch information
mcastorina authored Aug 7, 2024
1 parent d0726eb commit 39f5f54
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
3 changes: 2 additions & 1 deletion pkg/analyzer/analyzers/github/finegrained/finegrained.go
Original file line number Diff line number Diff line change
Expand Up @@ -1240,7 +1240,8 @@ func analyzeUserPermissions(client *gh.Client, user *gh.User) ([]Permission, err
for _, permFunc := range acctPermFuncMap {
access, err := permFunc(client, user)
if err != nil {
return nil, err
// TODO: Log error.
continue
}
perms = append(perms, access)
}
Expand Down
2 changes: 0 additions & 2 deletions pkg/analyzer/analyzers/postgres/postgres.go
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,6 @@ func AnalyzeAndPrintPermissions(cfg *config.Config, connectionStr string) {
color.Yellow("[!] Successfully connected to Postgres database.")
printUserRoleAndPriv(info.Role, info.RolePrivs)

printDBPrivs(info.DBs, info.User)

// Print db privs
if len(info.DBs) > 0 {
fmt.Print("\n\n")
Expand Down

0 comments on commit 39f5f54

Please sign in to comment.