[Detector] Cut out unneccessary false positive session tokens of AWSSession Key #3306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For AWS session token, substring is being searched to avoid false positive session tokens. Reference: https://nitter.poast.org/TalBeerySec/status/1816449053841838223#m
dustin-decker
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Based on the article, Session Key can be of 5 variants and can be easily identified based on sub-strings (
YXdz&Jb3JpZ2luX2Vj). Current implementation was only looking forYXdz. This PR includes check for another stringJb3JpZ2luX2Vj.Checklist:
make test-community)?make lintthis requires golangci-lint)?