[fix] - Add Size Method to BufferedReadSeeker and Refactor Context Timeout Handling in HandleFile #3307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcastorina
approved these changes
Sep 20, 2024
| } | ||
| } | ||
|
|
||
| // errorReader is an io.Reader that returns an error after reading a specified number of bytes. |
There was a problem hiding this comment.
Are you testing a non-EOF error? Otherwise io.LimitReader may be of use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR enhances the BufferedReadSeeker with a new Size method for determining the total size of the reader and improves the HandleFile function by centralizing context timeout management.
Changes:
Introduce
SizeMethod toBufferedReadSeeker:Added a
Sizemethod that efficiently retrieves the total size of the underlying reader for both seekable and non-seekable sources by utilizing the existingSeekmethod.Refactor Context Timeout Handling in
HandleFile:Moved the creation and management of the context timeout (
processingCtx) outside of each handler within theHandleFilefunction.Allows context timeouts to be propagated back to the caller, enabling better external handling and monitoring of timeout events.
Checklist:
make test-community)?make lintthis requires golangci-lint)?