Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul NPM detector #3705

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

rgmz
Copy link
Contributor

@rgmz rgmz commented Dec 2, 2024

Description:

This fixes #1455.

It supersedes #2264 which had a larger scope of changes (adding new detectors + updating existing detectors). I would like to get around to adding the new ones eventually.

Future work

These are minor and could either be done here or another PR.

  • Update UUID detector to ignore false positives.
     <UniqueIdentifier>{8CDEE807-BC53-E450-C8B8-4DEBB66742D4}</UniqueIdentifier>
    
    correlationId\u0022:\u00222b37bc2f-fa8d-404f-b10b-8a5f15939b52\u0022}"
    
    "codeUri": "https://xxxx.blob.core.windows.net:443/061273aa-2-d61bde93-80ee-5358-9871-99208b854f6a/src",
    

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

@rgmz rgmz force-pushed the feat/update-npm-v2 branch 10 times, most recently from d5206bb to 49c6217 Compare December 2, 2024 03:49
@rgmz rgmz marked this pull request as ready for review December 2, 2024 03:50
@rgmz rgmz requested review from a team as code owners December 2, 2024 03:50
@rgmz rgmz force-pushed the feat/update-npm-v2 branch 2 times, most recently from 82ce429 to 731175f Compare December 2, 2024 03:56
@rgmz rgmz mentioned this pull request Dec 2, 2024
6 tasks
@rgmz rgmz force-pushed the feat/update-npm-v2 branch 2 times, most recently from a235548 to cc7ec0c Compare December 2, 2024 18:43
@rgmz rgmz force-pushed the feat/update-npm-v2 branch 2 times, most recently from 1fa5a99 to 2603d9f Compare December 21, 2024 16:00
@rgmz rgmz force-pushed the feat/update-npm-v2 branch from 2603d9f to f31055a Compare December 31, 2024 14:47
@rgmz rgmz force-pushed the feat/update-npm-v2 branch from f31055a to f1b7605 Compare January 12, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

NpmToken detector should verify against the registry URL, if present
1 participant