Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

fixed an error for 'GET_DECODED_TRANSACTION_INPUT' when the 'transaction.input' was '0x' #4807

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

chinakids
Copy link

@chinakids chinakids commented Jul 20, 2022

Ganache

Thank you for contributing! Take a moment to review our contributing guidelines
to make the process easy and effective for everyone involved.

You must open an issue before embarking on any significant pull request, especially those that
add a new library or change existing tests, otherwise you risk spending a lot of time working
on something that might not end up being merged into the project.

Before opening a pull request, please ensure:

  • You have followed our contributing guidelines
  • Pull request has tests
  • Code is well-commented, linted and follows project conventions
  • Documentation is updated (if necessary)
  • Description explains the issue/use-case resolved and auto-closes related issues

Be kind to code reviewers, please try to keep pull requests as small and focused as possible :)

IMPORTANT: By submitting a patch via a Pull Request, you agree to allow the project
owners to license your work under the terms of the MIT License.

@chinakids
Copy link
Author

Transaction input was '0x' when transfer ETH to a contract address.
At this time, the absence of decodeddata will cause the system to report an error

@chinakids
Copy link
Author

image

@chinakids
Copy link
Author

#4803

Copy link
Author

@chinakids chinakids left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@chinakids chinakids marked this pull request as draft November 5, 2022 11:45
@chinakids chinakids marked this pull request as ready for review November 5, 2022 11:45
@chinakids
Copy link
Author

@Pemburu88 This PR has been completed and can be merged

@davidmurdoch
Copy link
Member

Thanks for the PR, and sorry for taking so long to review it. I think this is more properly handled by #5341

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants