Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use full path when creating new notebook #73

Merged
merged 1 commit into from
Nov 2, 2024

Conversation

mwcraig
Copy link
Contributor

@mwcraig mwcraig commented Oct 29, 2024

I think this fixes #72 by using the full path, rather than just the name of the notebook, when creating a new notebook.

The problem reported in #72 is that the notebook is always created in the root folder that jupyter was launched from (or at least that is where the file creation is attempted). If you are in a subfolder and the notebook does not already exist in the root folder, an error is raised, as reported in #72.

The other issue mentioned in #72 -- that sometimes the notebook launches but is connected to a copy in the root folder -- happens if you try to make the notebook in a subfolder and it also exists in the root folder. In that case openOrReveal opens up the one that exists in the root folder, though one also ends up with a copy in the working folder.

No idea if this is the right fix 😬

Copy link
Contributor

Binder 👈 Launch a Binder on branch mwcraig/jupyter_app_launcher/fix-72

@trungleduc trungleduc added the bug Something isn't working label Oct 29, 2024
@trungleduc
Copy link
Owner

Thanks @mwcraig, i will take a look this weekend

@trungleduc trungleduc merged commit 85c4f79 into trungleduc:main Nov 2, 2024
9 of 10 checks passed
@trungleduc
Copy link
Owner

Thanks @mwcraig

@trungleduc
Copy link
Owner

released in 0.3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notebook fails to open, with error, or opens in the wrong place
2 participants