Use full path when creating new notebook #73
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this fixes #72 by using the full path, rather than just the name of the notebook, when creating a new notebook.
The problem reported in #72 is that the notebook is always created in the root folder that jupyter was launched from (or at least that is where the file creation is attempted). If you are in a subfolder and the notebook does not already exist in the root folder, an error is raised, as reported in #72.
The other issue mentioned in #72 -- that sometimes the notebook launches but is connected to a copy in the root folder -- happens if you try to make the notebook in a subfolder and it also exists in the root folder. In that case
openOrReveal
opens up the one that exists in the root folder, though one also ends up with a copy in the working folder.No idea if this is the right fix 😬