-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deserialization of enums and add fuzzer #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sosthene-nitrokey
force-pushed
the
fixes
branch
2 times, most recently
from
February 20, 2023 15:07
7b3e2b0
to
522c6df
Compare
sosthene-nitrokey
force-pushed
the
fixes
branch
from
February 21, 2023 16:14
522c6df
to
0da927e
Compare
robin-nitrokey
approved these changes
Sep 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add unit tests for the fixed enum and u64 deserialization, otherwise LGTM.
Good idea. |
sosthene-nitrokey
force-pushed
the
fixes
branch
from
September 13, 2024 15:15
e739899
to
6b8dc58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch runs cargo fmt, fixes cilppy warnings, fixes a bug preventing the deserialization of enums with struct variants, and a bug affecting tuple variants.
It also adds some basic fuzzing infrastructure, which didn't find any crash (outside of the ones fixed by this PR) in 20min