-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump littlefs version #19
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some thoughts:
- Please add a changelog entry.
- I think the header patch only hides a missing dependency. If we want to be able to compile with clang, we should fix the underlying issue. On NixOS,
clang_multi
is the only package required for me and also findsstring.h
(even when settingCC=clang
). Not sure what is needed on Arch. - We should also add support for the
LFS_READONLY
andLFS_THREADSAFE
features added in v2.3.0.
Arch doesn't appear to have any such package, I already looked for it. I can also fix it by adding
Overall I'm in favour of not adding support for things that we don't plan to support in the |
This patch: - Bumps the littlefs version to the latest released (v2.9.3) - Adds a "multiversion" feature flag that exposes the littlefs feature of the same name
2a4055a
to
a913a47
Compare
Okay, then let’s skip the other new features. I think it would make sense to release this as v0.3 anyway to avoid accidental upgrades to the new 2.1 format. |
a9b7a59
to
c6dba7b
Compare
This patch: