Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Upgrade to 3.8.1 with tooltip updates #2962

Closed
wants to merge 3 commits into from
Closed

feat: Upgrade to 3.8.1 with tooltip updates #2962

wants to merge 3 commits into from

Conversation

werdnanoslen
Copy link
Contributor

Summary

This updates us to the latest uswds version, 3.8.1, which had two changes that required PRs here:

How To Test

  1. Run new tests
  2. Open tooltip stories and confirm (1) that you can hover on the tooltip body and (2) dismiss it by keyboard only with the Escape (and no other) key. Previously, we had set it so that any key would dismiss, which was neither helpful in general nor accessible by keyboard navigation.

@werdnanoslen werdnanoslen requested a review from a team as a code owner June 24, 2024 21:47
@github-actions GitHub Actions
Copy link
Contributor

Warnings
⚠️ This PR does not include changes to storybook, even though it affects component code.

Generated by 🚫 dangerJS against 35d84e2

@werdnanoslen werdnanoslen mentioned this pull request Jun 24, 2024
Open
@werdnanoslen
Copy link
Contributor Author

Merged into #2848

@werdnanoslen werdnanoslen deleted the an-3.8.1 branch June 24, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@werdnanoslen