Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bucket policy for new AWS Regions #316

Closed

Conversation

alexandervasylev
Copy link
Contributor

Changes proposed in this pull request:

AWS Principal in the bucket policy depends on AWS Region creation date: https://docs.aws.amazon.com/elasticloadbalancing/latest/classic/enable-access-logs.html#attach-bucket-policy

@alexandervasylev alexandervasylev marked this pull request as ready for review August 30, 2024 12:28
@amontalban
Copy link

Thanks @alexandervasylev we are having the same issue and this fixes the problem.

@nicomfer
Copy link

Thanks @alexandervasylev , This is also affecting NLB bucket policies statement.

modifying ELBv2 Load Balancer (arn:aws:elasticloadbalancing:ap-southeast-4:xxxx:loadbalancer/net/xxxxx/xxxxx) attributes: operation error Elastic Load Balancing v2: ModifyLoadBalancerAttributes, https response error StatusCode: 400, RequestID: 3be836as-fc100-4ae4-8186-23fx64873b25, api error ValidationError: Access Denied for bucket: xxxxx. Please check S3bucket permission

@esacteksab
Copy link
Contributor

Been a minute since this was open. Also looks like there are additional regions

ap-southeast-5
ap-southeast-7

If you're willing to update your PR off main with these new regions would be happy to merge and cut a release. Thanks!

@esacteksab
Copy link
Contributor

Thanks @alexandervasylev , This is also affecting NLB bucket policies statement.

modifying ELBv2 Load Balancer (arn:aws:elasticloadbalancing:ap-southeast-4:xxxx:loadbalancer/net/xxxxx/xxxxx) attributes: operation error Elastic Load Balancing v2: ModifyLoadBalancerAttributes, https response error StatusCode: 400, RequestID: 3be836as-fc100-4ae4-8186-23fx64873b25, api error ValidationError: Access Denied for bucket: xxxxx. Please check S3bucket permission

Looking at the docs they include an example bucket policy and it isn't using Service Principals like ELB and ALB do. I spent a little bit of time in the docs, and I can't find similar configuration requirements for an NLB. Definitely interested in addressing this if you can shed anymore light on things. This is getting done in #322 but happy to do another PR for NLB when we know more. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New AWS Regions
4 participants