Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Added a sort order parameter to activities handler #905

Merged
merged 1 commit into from
Nov 26, 2021

Conversation

bstasyszyn
Copy link
Contributor

Paging with descending sort order currently does not work with MongoDB (issue #893) so sorting of activities is temporarily (maybe permanently) set to ascending.

Signed-off-by: Bob Stasyszyn [email protected]

Paging with descending sort order currently does not work with MongoDB (issue trustbloc#893) so sorting of activities is temporarily (maybe permanently) set to ascending.

Signed-off-by: Bob Stasyszyn <[email protected]>
@cla-bot cla-bot bot added the cla-signed label Nov 26, 2021
@codecov
Copy link

codecov bot commented Nov 26, 2021

Codecov Report

Merging #905 (d20e54d) into main (e274a57) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #905      +/-   ##
==========================================
- Coverage   89.43%   89.37%   -0.06%     
==========================================
  Files         157      157              
  Lines       14227    14226       -1     
==========================================
- Hits        12724    12715       -9     
- Misses        922      929       +7     
- Partials      581      582       +1     
Impacted Files Coverage Δ
cmd/orb-server/startcmd/start.go 72.74% <100.00%> (ø)
pkg/activitypub/resthandler/activityhandler.go 93.69% <100.00%> (ø)
pkg/activitypub/resthandler/referencehandler.go 88.15% <100.00%> (-0.08%) ⬇️
pkg/activitypub/resthandler/resthandler.go 91.44% <100.00%> (ø)
pkg/activitypub/resthandler/serviceshandler.go 74.71% <100.00%> (ø)
...pub/service/inbox/httpsubscriber/httpsubscriber.go 90.12% <0.00%> (-9.88%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e274a57...d20e54d. Read the comment docs.

@bstasyszyn bstasyszyn merged commit b29209b into trustbloc:main Nov 26, 2021
@bstasyszyn bstasyszyn deleted the 481-3 branch November 26, 2021 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants