feat: Credential Status API - update vc status

Signed-off-by: Mykhailo Sizov <[email protected]>
trustbloc · Oct 18, 2022 · a6fa11b · a6fa11b
1 parent 03e09e9
commit a6fa11b
Show file tree

Hide file tree

Showing 20 changed files with 728 additions and 146 deletions.
diff --git a/cmd/vc-rest/startcmd/start.go b/cmd/vc-rest/startcmd/start.go
@@ -275,10 +275,10 @@ func buildEchoHandler(conf *Configuration, cmd *cobra.Command) (*echo.Echo, erro
 	verifierv1.RegisterHandlers(e, verifierController)
 
 	didConfigSvc := didconfiguration.New(&didconfiguration.Config{
-		VerifierProfileService:  verifierProfileSvc,
-		IssuerProfileService:    issuerProfileSvc,
-		IssuerCredentialService: issueCredentialSvc,
-		KmsRegistry:             kmsRegistry,
+		VerifierProfileService: verifierProfileSvc,
+		IssuerProfileService:   issuerProfileSvc,
+		Crypto:                 vcCrypto,
+		KmsRegistry:            kmsRegistry,
 	})
 
 	if conf.StartupParameters.devMode {

diff --git a/pkg/doc/vc/crypto/crypto.go b/pkg/doc/vc/crypto/crypto.go
@@ -150,8 +150,20 @@ type Crypto struct {
 	documentLoader ld.DocumentLoader
 }
 
-// SignCredentialLDP adds verifiable.LinkedDataProofContext to the vc.
-func (c *Crypto) SignCredentialLDP(
+func (c *Crypto) SignCredential(
+	signerData *vc.Signer, vc *verifiable.Credential, opts ...SigningOpts) (*verifiable.Credential, error) {
+	switch signerData.Format {
+	case vcsverifiable.Jwt:
+		return c.signCredentialJWT(signerData, vc, opts...)
+	case vcsverifiable.Ldp:
+		return c.signCredentialLDP(signerData, vc, opts...)
+	default:
+		return nil, fmt.Errorf("unknown signature format %s", signerData.Format)
+	}
+}
+
+// signCredentialLDP adds verifiable.LinkedDataProofContext to the VC.
+func (c *Crypto) signCredentialLDP(
 	signerData *vc.Signer, vc *verifiable.Credential, opts ...SigningOpts) (*verifiable.Credential, error) {
 	signOpts := &signingOpts{}
 	// apply opts
@@ -178,8 +190,8 @@ func (c *Crypto) SignCredentialLDP(
 	return vc, nil
 }
 
-// SignCredentialJWT returns vc in JWT format including the signature section.
-func (c *Crypto) SignCredentialJWT(
+// signCredentialJWT returns vc in JWT format including the signature section.
+func (c *Crypto) signCredentialJWT(
 	signerData *vc.Signer, vc *verifiable.Credential, opts ...SigningOpts) (*verifiable.Credential, error) {
 	signOpts := &signingOpts{}
 	// apply opts

diff --git a/pkg/doc/vc/crypto/crypto_test.go b/pkg/doc/vc/crypto/crypto_test.go
@@ -41,7 +41,7 @@ func TestCrypto_SignCredentialLDP(t *testing.T) { //nolint:gocognit
 			testutil.DocumentLoader(t),
 		)
 
-		signedVC, err := c.SignCredentialLDP(
+		signedVC, err := c.signCredentialLDP(
 			getTestSigner(), &verifiable.Credential{ID: "http://example.edu/credentials/1872"})
 		require.NoError(t, err)
 		require.Equal(t, 1, len(signedVC.Proofs))
@@ -181,7 +181,7 @@ func TestCrypto_SignCredentialLDP(t *testing.T) { //nolint:gocognit
 					vcSigner = tc.vcSigner
 				}
 
-				signedVC, err := c.SignCredentialLDP(
+				signedVC, err := c.signCredentialLDP(
 					vcSigner, &verifiable.Credential{ID: "http://example.edu/credentials/1872"},
 					tc.signingOpts...)
 
@@ -227,7 +227,7 @@ func TestCrypto_SignCredentialLDP(t *testing.T) { //nolint:gocognit
 		)
 		p := getTestSigner()
 		p.Creator = "wrongValue"
-		signedVC, err := c.SignCredentialLDP(
+		signedVC, err := c.signCredentialLDP(
 			p, &verifiable.Credential{ID: "http://example.edu/credentials/1872"})
 		require.Error(t, err)
 		require.Contains(t, err.Error(), "verificationMethod value wrongValue should be in did#keyID format")
@@ -239,7 +239,7 @@ func TestCrypto_SignCredentialLDP(t *testing.T) { //nolint:gocognit
 			&vdrmock.MockVDRegistry{ResolveValue: createDIDDoc("did:trustbloc:abc")},
 			testutil.DocumentLoader(t),
 		)
-		signedVC, err := c.SignCredentialLDP(
+		signedVC, err := c.signCredentialLDP(
 			getTestSignerWithCrypto(
 				&cryptomock.Crypto{SignErr: fmt.Errorf("failed to sign")}),
 			&verifiable.Credential{ID: "http://example.edu/credentials/1872"})
@@ -254,7 +254,7 @@ func TestCrypto_SignCredentialLDP(t *testing.T) { //nolint:gocognit
 
 		p := getTestSigner()
 
-		signedVC, err := c.SignCredentialLDP(
+		signedVC, err := c.signCredentialLDP(
 			p, &verifiable.Credential{ID: "http://example.edu/credentials/1872"},
 			WithPurpose("invalid"))
 		require.Error(t, err)
@@ -268,7 +268,7 @@ func TestCrypto_SignCredentialLDP(t *testing.T) { //nolint:gocognit
 
 		p := getTestSigner()
 
-		signedVC, err := c.SignCredentialLDP(
+		signedVC, err := c.signCredentialLDP(
 			p, &verifiable.Credential{ID: "http://example.edu/credentials/1872"},
 			WithPurpose(CapabilityInvocation))
 		require.NoError(t, err)
@@ -281,7 +281,7 @@ func TestCrypto_SignCredentialLDP(t *testing.T) { //nolint:gocognit
 
 		p := getTestSigner()
 
-		signedVC, err := c.SignCredentialLDP(
+		signedVC, err := c.signCredentialLDP(
 			p, &verifiable.Credential{ID: "http://example.edu/credentials/1872"},
 			WithPurpose(CapabilityInvocation))
 		require.NoError(t, err)
@@ -296,7 +296,7 @@ func TestCrypto_SignCredentialBBS(t *testing.T) {
 			testutil.DocumentLoader(t),
 		)
 
-		signedVC, err := c.SignCredentialLDP(
+		signedVC, err := c.signCredentialLDP(
 			&vc.Signer{
 				DID:           "did:trustbloc:abc",
 				SignatureType: "BbsBlsSignature2020",
@@ -683,7 +683,7 @@ func TestCrypto_SignCredentialJWT(t *testing.T) {
 				vdr:            tt.fields.getVDR(),
 				documentLoader: testutil.DocumentLoader(t),
 			}
-			got, err := c.SignCredentialJWT(tt.args.signerData, tt.args.getVC(), tt.args.opts...)
+			got, err := c.signCredentialJWT(tt.args.signerData, tt.args.getVC(), tt.args.opts...)
 			if (err != nil) != tt.wantErr {
 				t.Errorf("SignCredentialJWT() error = %v, wantErr %v", err, tt.wantErr)
 				return

diff --git a/pkg/doc/vc/signer.go b/pkg/doc/vc/signer.go
@@ -27,6 +27,7 @@ type Signer struct {
 	Creator                 string
 	SignatureType           vcsverifiable.SignatureType
 	KeyType                 kms.KeyType
+	Format                  vcsverifiable.Format               // VC format - LDP/JWT.
 	SignatureRepresentation verifiable.SignatureRepresentation // For LDP only.
 	KMS                     keyManager
 }
diff --git a/pkg/restapi/v1/issuer/controller.go b/pkg/restapi/v1/issuer/controller.go
@@ -13,6 +13,7 @@ import (
 	"context"
 	"errors"
 	"fmt"
+	"net/http"
 	"strings"
 	"time"
 
@@ -69,6 +70,7 @@ type oidc4VCService interface {
 type vcStatusManager interface {
 	GetRevocationListVC(id string) (*verifiable.Credential, error)
 	GetCredentialStatusURL(issuerProfileURL, issuerProfileID, statusID string) (string, error)
+	UpdateVCStatus(signer *vc.Signer, profileName, CredentialID, status string) error
 }
 
 type Config struct {
@@ -324,5 +326,55 @@ func (c *Controller) GetCredentialsStatus(ctx echo.Context, profileID string, st
 // PostCredentialsStatus updates credential status.
 // POST /issuer/profiles/{profileID}/credentials/status.
 func (c *Controller) PostCredentialsStatus(ctx echo.Context, profileID string) error {
+	var body UpdateCredentialStatusRequest
+
+	if err := util.ReadBody(ctx, &body); err != nil {
+		return err
+	}
+
+	if err := c.updateCredentialStatus(ctx, &body, profileID); err != nil {
+		return err
+	}
+
+	return ctx.NoContent(http.StatusOK)
+}
+
+func (c *Controller) updateCredentialStatus(ctx echo.Context, body *UpdateCredentialStatusRequest,
+	profileID string) error {
+	oidcOrgID, err := util.GetOrgIDFromOIDC(ctx)
+	if err != nil {
+		return err
+	}
+
+	profile, err := c.accessOIDCProfile(profileID, oidcOrgID)
+	if err != nil {
+		return err
+	}
+
+	keyManager, err := c.kmsRegistry.GetKeyManager(profile.KMSConfig)
+	if err != nil {
+		return fmt.Errorf("failed to get kms: %w", err)
+	}
+
+	if body.CredentialStatus.Type != credentialstatus.StatusList2021Entry {
+		return resterr.NewValidationError(resterr.InvalidValue, "CredentialStatus.Type",
+			fmt.Errorf("credential status %s not supported", body.CredentialStatus.Type))
+	}
+
+	signer := &vc.Signer{
+		Format:                  profile.VCConfig.Format,
+		DID:                     profile.SigningDID.DID,
+		Creator:                 profile.SigningDID.Creator,
+		SignatureType:           profile.VCConfig.SigningAlgorithm,
+		KeyType:                 profile.VCConfig.KeyType,
+		KMS:                     keyManager,
+		SignatureRepresentation: profile.VCConfig.SignatureRepresentation,
+	}
+
+	err = c.vcStatusManager.UpdateVCStatus(signer, profile.Name, body.CredentialID, body.CredentialStatus.Status)
+	if err != nil {
+		return resterr.NewSystemError("VCStatusManager", "UpdateVCStatus", err)
+	}
+
 	return nil
 }