Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: attachment proof #1740

Merged
merged 8 commits into from
Jul 4, 2024
Merged

feat: attachment proof #1740

merged 8 commits into from
Jul 4, 2024

Conversation

skynet2
Copy link
Member

@skynet2 skynet2 commented Jul 4, 2024

No description provided.

@cla-bot cla-bot bot added the cla-signed label Jul 4, 2024
Copy link

codecov bot commented Jul 4, 2024

Codecov Report

Attention: Patch coverage is 98.01980% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.99%. Comparing base (e4f97de) to head (206b421).
Report is 7 commits behind head on main.

Files Patch % Lines
pkg/service/oidc4vp/attachments.go 97.64% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1740      +/-   ##
==========================================
+ Coverage   85.82%   85.99%   +0.16%     
==========================================
  Files         182      183       +1     
  Lines       12560    12741     +181     
==========================================
+ Hits        10780    10956     +176     
- Misses       1313     1315       +2     
- Partials      467      470       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skynet2 skynet2 marked this pull request as ready for review July 4, 2024 15:08
@fqutishat fqutishat merged commit b7a9286 into trustbloc:main Jul 4, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants