Remove uses of twisted.internet.defer.returnValue #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
returnValue() can be replaced with plain return in Python 3 code. returnValue() has been deprecated in Twisted 24.7.0 and will be removed soon.
p12tic
force-pushed
the
remove-twisted-defervalue
branch
from
7f030e5 to
7842e2a
Compare
|
Although the change of this PR can be also applied clearly against develop branch, I think you should make PR against develop branch rather than master branch. (Please see ProjectGuide and commit graph) |
|
@futatuki Thanks, I rebased the PR. |
futatuki
added a commit
to futatuki/OpenDKIM
that referenced
this pull request
Dec 29, 2024
…d-defervalue contrib/repute: Remove uses of twisted.internet.defer.returnValue trusteddomainproject#237
futatuki
added a commit
to futatuki/OpenDKIM
that referenced
this pull request
Dec 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
returnValue() can be replaced with plain return in Python 3 code. returnValue() has been deprecated in Twisted 24.7.0 and will be removed soon.