Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: reduce default importers to only those used in V1 #1084

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jcrossley3
Copy link
Contributor

This will facilitate the transition of V1 users to V2.

Relates to #953

This will facilitate the transition of V1 users to V2.

Signed-off-by: Jim Crossley <[email protected]>
Copy link
Contributor

@ctron ctron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this is never exposed to a v1 user, I am against merging this. To my understanding also @mid998 is relying on this sometimes.

@jcrossley3
Copy link
Contributor Author

I just think the essence of the feature is better conveyed through a minimum of default examples. Thirteen importers is overwhelming to a new user unfamiliar with the feature. Worse, the only sample SBOM importer doesn't even appear on the first page!

IMO the 10 importers I removed belong in the docs as examples accompanied by supporting text descriptions of each field.

@ctron
Copy link
Contributor

ctron commented Dec 9, 2024

I agree that 10 importers might not be the best approach. On the other side, ripping out the existing other times leaves us without any example of using OSV, CWE, ClearlyDefined, … In order to compensate, we should improve docs to enable users to get there. Or, just stick to the existing importers, on which PM relies today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants