[Rust/Eth]: Replace C++ Ethereum MessageSigner #3458

satoshiotomakan · 2023-09-29T12:33:38Z

Description

Add and implement Ethereum MessageSigner in Rust and integrate it to C++.

How to test

Run Rust, C++, iOS, Android tests

TODO (future improvements)

Add TWMessageSignerSign, TWMessageSignerVerify, TWMessageSignePreImageHashes FFI functions;
Deprecate TWEthereumMessageSigner* FFIs.
Remove C++ Ethereum/ABI/* params

Types of changes

Checklist

Create pull request as draft initially, unless its complete.
Add tests to cover changes as needed.
Update documentation as needed.
If there is a related Issue, mention it in the description.

If you're adding a new blockchain

I have read the guidelines for adding a new blockchain.

* TODO: add tests for `TWEthereumAbiDecodeContractCall`

* TODO refactor Ethereum::ABI::FunctionV2: move impl to cpp file * TODO finish Ethereum::ABI::FunctionV2 with InArray params * TODO implement TWEthereumAbiFunctionGetType

* Move some tests to Rust

* Add ABI Contract

* Add Android tests

* Add ZeroizeOnDrop for secp256k1 and nist256p1 Private keys

* Refactor U256 serializing methods

* TODO add `tw_signer_sign_message`

… C++ codebase

Milerius

Good job, just few questions.

rust/tw_evm/src/abi/encode.rs

src/Ethereum/ABI/Function.cpp

satoshiotomakan added 30 commits August 21, 2023 09:32

feat(eth): Design Ethereum ABI

f9a2ce3

feat(eth): Change Ethereum ABI interface

d7b71b8

feat(eth): Add TWEthereumAbi.h functions

4719cab

feat(eth): Add NamedParam

3af2097

[Eth]: Implement Contract Call Decoding

d1b5f68

[eth]: Add tw_ethereum_abi_decode_contract_call and integrate it to C++

70533d5

* TODO: add tests for `TWEthereumAbiDecodeContractCall`

[eth]: Implement Params Decoding with Json and Proto ABI

ce39659

[eth]: Add tw_ethereum_abi_decode_contract_call and integrate it to C++

ea42c1d

* TODO refactor Ethereum::ABI::FunctionV2: move impl to cpp file * TODO finish Ethereum::ABI::FunctionV2 with InArray params * TODO implement TWEthereumAbiFunctionGetType

[eth]: Add tw_ethereum_abi_function_get_type and integrate it to C++

d86dab3

[eth]: Reimplement AddInArray

cff3f3f

[eth]: Implement Function encoding in Rust

bd1331b

[eth]: Integrate tw_ethereum_abi_encode_function into C++

c7bddcf

[eth]: Add and implement Value Decoding in Rust

4fe38e7

[eth]: Implement custom fmt::Display for Token

be0995e

[eth]: Integrate tw_ethereum_abi_decode_value into C++

6fe56ad

[eth]: Clean up C++ code

07e6b89

* Move some tests to Rust

[eth]: Clean up Rust code, increase code coverage

afd2b41

[eth]: Rename ABI types

b3d2b64

[eth]: Introduce Proto::AbiError

59f87d7

* Add ABI Contract

[eth]: Extend Rust tests

69e3433

[eth]: Fix Android, iOS tests

6dd3bff

[eth]: Optimize Proto interface

129f6fe

* Add Android tests

[eth]: Add iOS tests

756fd93

Merge branch 'dev' into s/rust-eth-abi

c2faa5b

[eth]: Decrease code coverage to 90.0

89b368c

[eth]: Add message signer, implement signing simple messages

0abbdeb

[eth]: Fix PR issues

26a4592

* Add ZeroizeOnDrop for secp256k1 and nist256p1 Private keys

[eth]: Increase code coverage

1d7d170

[eth]: Add and implement signature verifying

f0e090e

[eth]: WIP EIP712 in progress

4e08f2c

* Refactor U256 serializing methods

satoshiotomakan added 8 commits September 28, 2023 15:06

[eth]: Fix Int encoding, formatting, serializing

985c52f

Merge branch 's/rust-eth-abi' into s/rust-eth-msg

b18ceeb

[eth]: Finish implementing EIP712 in Rust

728f846

* TODO add `tw_signer_sign_message`

[eth]: Add more tests

c21398b

* TODO add `tw_signer_sign_message`

[eth]: Add tw_message_signer_sign and tw_message_signer_verify

baa7407

[eth]: Integrate Rust FFI interface into C++ codebase

9fd70cd

[eth]: Add tw_message_signer_pre_image_hashes and integrate it into…

8d68ca0

… C++ codebase

Merge branch 'dev' into s/rust-eth-msg

cfd5e35

satoshiotomakan marked this pull request as ready for review September 29, 2023 12:46

satoshiotomakan requested review from Milerius and lamafab as code owners September 29, 2023 12:46

satoshiotomakan added 4 commits September 29, 2023 14:47

feat(eth) Trigger CI

0ba0aa6

[eth]: Fix KotlinMultiplatform CI

7d898ae

[eth]: Clean C++ codebase

9f3b8e0

[eth]: Remove C++ ABI implementation

1830cb5

satoshiotomakan changed the title ~~[Rust/Eth]: Replace C++ Ethereum ABI implementation~~ [Rust/Eth]: Replace C++ Ethereum MessageSigner Sep 29, 2023

Milerius reviewed Sep 29, 2023

View reviewed changes

rust/tw_evm/src/abi/encode.rs Show resolved Hide resolved

src/Ethereum/ABI/Function.cpp Show resolved Hide resolved

Milerius approved these changes Oct 2, 2023

View reviewed changes

Milerius merged commit eb2d48f into dev Oct 3, 2023

Milerius deleted the s/rust-eth-msg branch October 3, 2023 07:51

satoshiotomakan added a commit that referenced this pull request Oct 6, 2023

[Rust/Eth]: Replace C++ Ethereum MessageSigner (#3458)

93c1c1d

satoshiotomakan mentioned this pull request Oct 9, 2023

[Dev/UnderAudit]: Dev<->Master #3120

Merged

12 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Rust/Eth]: Replace C++ Ethereum MessageSigner #3458

[Rust/Eth]: Replace C++ Ethereum MessageSigner #3458

satoshiotomakan commented Sep 29, 2023 •

edited

Loading

Milerius left a comment

[Rust/Eth]: Replace C++ Ethereum MessageSigner #3458

[Rust/Eth]: Replace C++ Ethereum MessageSigner #3458

Conversation

satoshiotomakan commented Sep 29, 2023 • edited Loading

Description

How to test

TODO (future improvements)

Types of changes

Checklist

Milerius left a comment

Choose a reason for hiding this comment

satoshiotomakan commented Sep 29, 2023 •

edited

Loading